chore: pin version of golangci-lint #13238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
reviewed
Sep 11, 2022
julienrbrt
reviewed
Sep 11, 2022
There was a problem hiding this comment.
+1 for pinning the version, but I don't think we need to re-add it as dependency.
Instead, we could add go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0 in the Makefile for make lint, make lint-fix and make format. This cleans up quite a bit the go.mod.
can give this a go. |
tac0turtle
force-pushed
the
marko/linting-fix
branch
from
39d62c3 to
bebd102
Compare
tac0turtle
changed the title
tac0turtle
changed the title
19 tasks
julienrbrt
pushed a commit
that referenced
this pull request
Sep 13, 2022
* pin point version fo golangci-lint * remove dep * version variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change